Murano API: Implementing actions API #843
Conversation
Sync with master
* Introduced new models for internal service info and action info * Added the corresponding unit-tests * Next step is implementins Actions API
|
Besides the question above this looks very good. Many thanks for contributing @nmakhotkin |
|
Hi @auhlig! Sorry but I don't see any question from you. |
| Map<String, Object> serviceMap = mapper.readValue(json, Map.class); | ||
|
|
||
| // Need to remove internal service info from test json string. | ||
| serviceMap.remove("?"); |
There was a problem hiding this comment.
I'm wondering why that is necessary.
There was a problem hiding this comment.
Yes. Let me explain. The whole murano service structure json looks as the following:
{
"key1": "val1",
"key2": "val2",
...
"keyN": "valN",
"?": {
..<service internal data like id, type, name etc.>..
}
}
So I divide the application class model onto 2 parts: service internal info (which is all in "?" key) and all other app-related info (arbitrary data). Obviously, serviceMap here contains both data and service info but there is assertion only for data part. Without deletion value in "?" key this assertion won't work.
There was a problem hiding this comment.
Makes sense. Thanks for explaining.
|
@nmakhotkin Can you see the comment now? What do you think on this PR @vinodborole ? |
|
Thanks, now I see. Btw, this PR is WIP for now till I submit action API implementation itself. |
* Implemented API methods for:
- list available actions
- get specific action
- find action by name
- call action
- get result of an action
- call & wait for the result
* Tested on real environment
nmakhotkin
changed the title
|
@auhlig, @vinodborole, PR is ready for review now. |
|
Nice work. |
|
Thanks @auhlig @vinodborole! |
2 participants
No description provided.