Session_timeout bug fix & Local Build Process fixup#119
Closed
pavelnemirovsky wants to merge 17 commits intoContentSquare:masterfrom
Closed
Session_timeout bug fix & Local Build Process fixup#119pavelnemirovsky wants to merge 17 commits intoContentSquare:masterfrom
pavelnemirovsky wants to merge 17 commits intoContentSquare:masterfrom
Conversation
…ue to Datadog lib)
vfoucault
reviewed
May 24, 2021
Contributor
vfoucault
left a comment
vfoucault
left a comment
There was a problem hiding this comment.
I believe it would be better to switch to goreleaser with github actions. It would save the hassle to deal with local file, and would ease the release process for new tags.
Could you also squash your commits. Thx
Contributor
Author
|
@vfoucault yes, that's exactly what I proposed in my original PR since there is no automatic versioning and artifact building. Let's do it, Let's squash once it will be merged into master. |
pavelnemirovsky
changed the title
Contributor
|
Hello @pavelnemirovsky , github actions are now available in chproxy. Could you rebase your PR so we can leverage the fix you'd submitted for session timeout? |
Collaborator
|
I'm closing this PR since it has been stale for too long. Feel free to re open it if you want to finish it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In continue of #117