Skip to content

Conversation

@saksham-gera
Copy link
Contributor

fix #137 ,

I've made the required changes in concore.py and concoredocker.py
will soon raise a request for concoredocker.java too.

thanks

@saksham-gera
Copy link
Contributor Author

@pradeeban please review and let me know if any modifications are required.

@pradeeban pradeeban merged commit c51d270 into ControlCore-Project:dev Mar 4, 2025
@pradeeban
Copy link
Member

Thanks @saksham-gera, merged! Just letting you know, concoredocker.java is experimental. Any java implementation is untested.

@saksham-gera
Copy link
Contributor Author

saksham-gera commented Mar 4, 2025

Okay sir,
I think I should put concoredocker.java on hold for now since it is untested, and I may encounter multiple unrelated issues during testing.
or i'll only test if my changes wont cause any major change in logic and will push it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants