Options button features in API updated #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Interesting. Last year, one of the GSoC students (Amit?) had a similar issue and made the changes to mkconcore.py as you proposed. Or at least I remember it like that. Perhaps, he never created the pull request to merge. Anyway, merging. Feel free to send more pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pradeeban
It can be noticed that "chmod +x */*" is added to makestudy and makedocker scripts. It is because when I executed them in the newly installed Ubuntu 20.04, a permission denied error was coming even while executing all methods (even from CLI).
Moreover, (after makestudy is executed) for any posix system, the interpreter directive (shebang) is not present in the scripts of params and unlock. The same goes for the case of makedocker execution, for any script created the interpreter directive (shebang) is absent. Therefore, I made some changes in mkconcore.py. If you remember in Friday's meeting I was getting an error Exec format error: './build', it was because of this issue only. Even though from CLI we are able to execute them, but not from API calls.
Let me know if there are any other ways to deal with it or any changes.
Thank You