-
Notifications
You must be signed in to change notification settings - Fork 116
Move Utilities.toRawValue to core-vtype #2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Utilities.toRawValue to core-vtype #2912
Conversation
georgweiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, enum array should be converted to list of ints.
|
Enum array is now list of ints. Think I might have broken a test in the process, which I will fix. |
|
@kasemir I think this is ready to merge now. The returned datatype for the enumarray is now |
|
The phoebus/core/pv/src/main/java/org/phoebus/pv/PV.java Lines 211 to 222 in 3f6be6c
|
kasemir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
|
@jembishop, I'm afraid this PR was approved a bit too quickly. I suspect your development branch was not quite up-to-date, and I did not notice. |
|
@georgweiss I didn't realize that sorry. I will raise another PR to fix this. |
|
@georgweiss This is fixed here #2937 |
Hi there, in the process of doing another pull request I found that it would be a good idea to refactor the
Utilities.toRawValuemethod in the save-and-restore ui code into the sharedvtypelibrary. This is because converting aVTypeto a native java object was useful in my usecase and sounds like a generally useful thing to want to do.I also thought it would be best to take the associated
VDisconnectedDatatype into thevtypelibrary as well, given it shows up in theUtilities.toRawValuetests.Another minor change when making the modifications to the tests was to use wildcard import for the V types as they now pretty much import all the classes into the file.