-
Notifications
You must be signed in to change notification settings - Fork 116
#2968 annunciator #2973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2968 annunciator #2973
Conversation
app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/annunciator/Annunciator.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/org/phoebus/applications/alarm/freetts/annunciator/FreeTTSAnnunciator.java
Show resolved
Hide resolved
|
@tynanford can you try the updated version |
|
@shroffk Yes had a chance to test today, looking good! When I build with When I just build from this branch though, the product pom.xml contains both app-alarm-freetts-annunciator and app-alarm-audio-annunciator. And this produces behavior where both kevin16 and the audio clip are playing at the same time. How do we handle this with other pluggable systems in phoebus? I think it could confuse new users who just clone from github and build phoebus |
|
@tynanford you are right about the duplicate annunciators. People using the common product will get the freetts one... but site specific products will have the ability to explicitly include the annunciator they want to use... in the ALS-U case you can use the audio one. Others will have to include the freetts one. |
|
That makes sense to me, looks good. Added Han as a reviewer as well |
|
well looks like I can't add Han as a "reviewer" so @jeonghanlee , any issues before it is merged? |
...rm/ui/src/main/java/org/phoebus/applications/alarm/ui/annunciator/AnnunciatorController.java
Outdated
Show resolved
Hide resolved
|
Sorry, I have fixed the SPI contributions being constructed each time. |
|
I am ready to merge this... at the monthly meeting I mentioned how after this PR is merged site specific products will have to explicitly include the annunciator they want to use. |
|
Just for the reference, BBC released many sound samples as a free usage for not commercial usages. |
Work on making the annunciator plugable