Skip to content

Add tab context menu items for easier access to (file) resources #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgweiss merged 12 commits into from
Apr 5, 2024
Merged

Add tab context menu items for easier access to (file) resources #2993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
728151d
New context menu items for DockItemWithInput tab
georgweiss Mar 25, 2024
acae939
Merge branch 'master' into CSSTUDIO-1881-tab-context-menu
georgweiss Apr 2, 2024
8e61ba6
Update to FileBrowserController to support highlighting of file
georgweiss Apr 2, 2024
fa27f6b
Handle http(s) resources, add null check before configuring context menu
georgweiss Apr 2, 2024
1c554e3
Adding some comments/Javadoc
georgweiss Apr 3, 2024
ec50585
Typos...
georgweiss Apr 3, 2024
f918f3e
Desktop.isSupported call needed to avoid UI hand on (at least) Ubunbtu
georgweiss Apr 3, 2024
e994c41
Removed 'Show in native file browser' as this does not work on Linux
georgweiss Apr 3, 2024
bb46dcc
Changes based on review feed-back
georgweiss Apr 4, 2024
a77936d
Typo
georgweiss Apr 5, 2024
9829a02
Removed need for class variable
georgweiss Apr 5, 2024
e15a7a3
Update due to reversed condition
georgweiss Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/filebrowser/src/main/java/org/phoebus/applications/filebrowser/FileBrowser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class FileBrowser implements AppInstance

private FileBrowserController controller;

FileBrowser(final AppDescriptor app, final File directory)
FileBrowser(final AppDescriptor app, final File file)
{
this.app = app;

Expand All @@ -58,8 +58,14 @@ public class FileBrowser implements AppInstance
final DockItem tab = new DockItem(this, content);
DockPane.getActiveDockPane().addTab(tab);

if (controller != null && directory != null)
controller.setRoot(directory);
if (controller != null && file != null){
if(file.isDirectory()){
controller.setRoot(file);
}
else{
controller.setRootAndHighlight(file);
}
}

tab.addClosedNotification(controller::shutdown);
}
Expand Down
Loading