ISSUE-3368: Fix display/beahviour of 'not_enabled' control widgets #3418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to apply the not_enabled css style to the widget and show the no_write cursor.
…method ... in parent for consistent and uniform behaviour across widgets. Some widgets were being disabled which removes the context menu so these have been switched ot just apply the style. In addition some widgets were still trying to write to 'no_write' PVs causing exceptions in the log. These have been fixed by changing whether the widget is enabled first.
This should occur when there is only a single action to write to a PV that is non-writeable. In any other case the actionbutton should be enabled to run other actions attached to it.
kasemir
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues that were discovered while testing the 'not_enabled' behaviour of control widgets when relating to a PV which has the 'no-write' property. Please see #3368 for a full list of issues and discussion.
Summary of changes:
setDisabledLook(...)).enabledstatus before trying to write to a PV to stop exceptions being thrown in the logs..not_enabledcss class so that widgets do not show hover-over or click color changes when they should look 'disabled' - see video of interactions with a ChoiceButton in issue Display of widgets for 'no_write' PVs #3368