PVA: Track searches by CID #3449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This scenario was fun to read about |
Collaborator
Author
To me, network protocol issues like these always start out as a horror scenario. You need several PVs to duplicate the problem, then increase the log level or capture Wireshark traces. Either way, you get many pages of protocol dumps and wonder where to start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3446
In #3430, PVA searches were properly cleaned up once a reply arrived... by name.
When using PVs "pva://x/field1" and "pva://x/field2", these would both search for "x", then use different "field(...)" specs in the subscription. Since searches were cleaned by name, a search might get cleared before it ever went out.
This update tracks searches by client channel ID, so only the search that received a reply gets cleared.