CSSTUDIO-3336 Bugfix: Remove logging of warning when 'resource_name' is not a URL and clarify comment. #3470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not a URL and clarify comment.
kasemir
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the logging of the warning when
resource_nameis not a URL in the functioncanOpenUrl(). It also clarifies the comment describing the functioncanOpenUrl().The logging of this warning was introduced in the pull request #3246. It logs a warning when a resource is not a URL. However,
canOpenUrl()is called in the functiondoResolveResource()in order to determine whether a given resource is specified as a URL or not, and it is not an error if it is not a URL. If the resource is not a URL,canOpenUrl()returnsfalse, and an attempt is made to load the given resource as a file instead.If the resource is also not a file path, then the function
doResolveResource()logs a warning of the form"<resource> is not resolved".