-
Notifications
You must be signed in to change notification settings - Fork 693
fix: Rider config path and add MCP registry manifest #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rider config path and add MCP registry manifest #604
Conversation
- Fix RiderConfigurator to use correct GitHub Copilot config path: - Windows: %LOCALAPPDATA%\github-copilot\intellij\mcp.json - macOS: ~/Library/Application Support/github-copilot/intellij/mcp.json - Linux: ~/.config/github-copilot/intellij/mcp.json - Add mcp.json for GitHub MCP Registry support: - Enables users to install via coplaydev/unity-mcp - Uses uvx with mcpforunityserver from PyPI
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the Rider GitHub Copilot MCP client to write its configuration to the official GitHub Copilot IntelliJ paths across all platforms and introduces a top-level mcp.json manifest to support installation via the GitHub MCP Registry using the PyPI-distributed mcpforunityserver. Updated class diagram for RiderConfigurator MCP pathsclassDiagram
class McpClient {
string name
string windowsConfigPath
string macConfigPath
string linuxConfigPath
bool IsVsCodeLayout
}
class JsonFileMcpConfigurator {
+JsonFileMcpConfigurator(mcpClient)
+Configure()
}
class RiderConfigurator {
+RiderConfigurator()
}
RiderConfigurator --|> JsonFileMcpConfigurator
JsonFileMcpConfigurator o--> McpClient
class Environment {
+static string GetFolderPath(specialFolder)
}
class Path {
+static string Combine(part1, part2, part3, part4, part5)
}
RiderConfigurator ..> Environment : uses
RiderConfigurator ..> Path : uses
McpClient : windowsConfigPath = LocalApplicationData/github-copilot/intellij/mcp.json
McpClient : macConfigPath = UserProfile/Library/Application Support/github-copilot/intellij/mcp.json
McpClient : linuxConfigPath = UserProfile/.config/github-copilot/intellij/mcp.json
McpClient : IsVsCodeLayout = true
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
📝 WalkthroughWalkthroughThe PR modifies RiderConfigurator.cs to update MCP configuration paths from JetBrains Rider directories to GitHub Copilot IntelliJ directories across Windows, macOS, and Linux platforms. Additionally, a new mcp.json configuration file is introduced defining the MCP server setup for unity-mcp using stdio communication with uvx. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix RiderConfigurator to use correct GitHub Copilot config path: - Windows: %LOCALAPPDATA%\github-copilot\intellij\mcp.json - macOS: ~/Library/Application Support/github-copilot/intellij/mcp.json - Linux: ~/.config/github-copilot/intellij/mcp.json - Add mcp.json for GitHub MCP Registry support: - Enables users to install via coplaydev/unity-mcp - Uses uvx with mcpforunityserver from PyPI
* feat: Add CLI for Unity MCP server - Add click-based CLI with 15+ command groups - Commands: gameobject, component, scene, asset, script, editor, prefab, material, lighting, ui, audio, animation, code - HTTP transport to communicate with Unity via MCP server - Output formats: text, json, table - Configuration via environment variables or CLI options - Comprehensive usage guide and unit tests * Update based on AI feedback * Fixes main.py error * Update for further error fix * Update based on AI * Update script.py * Update with better coverage and Tool Readme * Log a message with implicit URI changes Small update for #542 * Minor fixes (#602) * Log a message with implicit URI changes Small update for #542 * Log a message with implicit URI changes Small update for #542 * Add helper scripts to update forks * fix: improve HTTP Local URL validation UX and styling specificity - Rename CSS class from generic "error" to "http-local-url-error" for better specificity - Rename "invalid-url" class to "http-local-invalid-url" for clarity - Disable httpServerCommandField when URL is invalid or transport not HTTP Local - Clear field value and tooltip when showing validation errors - Ensure field is re-enabled when URL becomes valid * Docker mcp gateway (#603) * Log a message with implicit URI changes Small update for #542 * Update docker container to default to stdio Replaces #541 * fix: Rider config path and add MCP registry manifest (#604) - Fix RiderConfigurator to use correct GitHub Copilot config path: - Windows: %LOCALAPPDATA%\github-copilot\intellij\mcp.json - macOS: ~/Library/Application Support/github-copilot/intellij/mcp.json - Linux: ~/.config/github-copilot/intellij/mcp.json - Add mcp.json for GitHub MCP Registry support: - Enables users to install via coplaydev/unity-mcp - Uses uvx with mcpforunityserver from PyPI * Use click.echo instead of print statements * Standardize whitespace * Minor tweak in docs * Use `wait` params * Unrelated but project scoped tools should be off by default * Update lock file * Whitespace cleanup * Update custom_tool_service.py to skip global registration for any tool name that already exists as a built‑in. * Avoid silently falling back to the first Unity session when a specific unity_instance was requested but not found. If a client passes a unity_instance that doesn’t match any session, this code will still route the command to the first available session, which can send commands to the wrong project in multi‑instance environments. Instead, when a unity_instance is provided but no matching session_id is found, return an error (e.g. 400/404 with "Unity instance '' not found") and only default to the first session when no unity_instance was specified. Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * Update docs/CLI_USAGE.md Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * Updated the CLI command registration to only swallow missing optional modules and to surface real import-time failures, so broken command modules don’t get silently ignored. * Sorted __all__ alphabetically to satisfy RUF022 in __init__.py. * Validate --params is a JSON object before merging. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Shutong Wu <51266340+Scriptwonder@users.noreply.github.com> Co-authored-by: dsarno <david@lighthaus.us> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
Fix Rider/IntelliJ GitHub Copilot MCP configuration paths and add mcp.json manifest for GitHub MCP Registry support. Fixes #599
Type of Change
Changes Made
%LOCALAPPDATA%\github-copilot\intellij\mcp.json~/Library/Application Support/github-copilot/intellij/mcp.json~/.config/github-copilot/intellij/mcp.jsoncoplaydev/unity-mcpuvxwithmcpforunityserverfrom PyPITesting/Screenshots/Recordings
mcp.jsonis written to correct path (%LOCALAPPDATA%\github-copilot\intellij\mcp.json)Related Issues
Additional Notes
Summary by Sourcery
Fix GitHub Copilot MCP configuration for JetBrains Rider and add registry manifest support.
New Features:
Bug Fixes:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.