Skip to content

fix(guardrails): harden infrastructure agent permissions #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terisuke merged 1 commit into from
Apr 6, 2026
+24 −1
Merged

fix(guardrails): harden infrastructure agent permissions #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/guardrails/profile/agents/cloud-architect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@ permission:
"*": allow
"*.env*": deny
"*credentials*": deny
"*.pem": deny
"*.key": deny
"*secret*": deny
grep:
"*": allow
"*.env*": deny
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grep permission rules are missing "*credentials*": deny, which is present in the security-engineer baseline. Without it, this agent can still grep for credential-related patterns and potentially expose secret material in grep output. Add the credentials deny rule to the grep block.

Suggested change
"*.env*": deny
"*.env*": deny
"*credentials*": deny

Copilot uses AI. Check for mistakes.
"*.pem": deny
"*.key": deny
"*secret*": deny
glob: allow
edit:
"*": deny
Expand Down
13 changes: 12 additions & 1 deletion packages/guardrails/profile/agents/deployment-engineer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@ permission:
"*": allow
"*.env*": deny
"*credentials*": deny
"*.pem": deny
"*.key": deny
"*secret*": deny
grep:
"*": allow
"*.env*": deny
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grep permission rules don’t deny *credentials* (the security-engineer agent does). Because grep permission checks apply to the search pattern, this still allows grepping for credential material and could leak secrets via grep results. Add "*credentials*": deny to the grep block.

Suggested change
"*.env*": deny
"*.env*": deny
"*credentials*": deny

Copilot uses AI. Check for mistakes.
"*.pem": deny
"*.key": deny
"*secret*": deny
glob: allow
edit:
"*": allow
Expand All @@ -18,13 +24,18 @@ permission:
"*": deny
"docker build*": allow
"docker compose*": allow
"docker compose push*": deny
"docker push*": deny
Comment on lines 24 to +28
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This agent now hard-denies docker push* / docker compose push*, but the guidance text later in the file says to never run docker push without explicit approval. Since deny means it can’t be approved at runtime, update the guidance to reflect that pushes are disallowed for this agent (or change the rule to ask if approval should be possible).

Copilot uses AI. Check for mistakes.
"docker ps*": allow
"docker images*": allow
"docker logs*": allow
"kubectl get*": allow
"kubectl describe*": allow
"kubectl logs*": allow
"kubectl rollout*": allow
"kubectl rollout status*": allow
"kubectl rollout history*": allow
"kubectl rollout restart*": ask
"kubectl rollout undo*": ask
"git diff*": allow
"git status*": allow
"git log*": allow
Expand Down
6 changes: 6 additions & 0 deletions packages/guardrails/profile/agents/terraform-engineer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ permission:
"*.env*": deny
"*credentials*": deny
"*.tfvars": deny
"*.pem": deny
"*.key": deny
"*secret*": deny
grep:
"*": allow
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the grep permission rules, *credentials* is not denied (unlike security-engineer.md, which denies it). Since grep permissions are evaluated against the search pattern, this agent can still grep for credentials and potentially surface secret values. Add a "*credentials*": deny entry in the grep block (keeping it after "*": allow).

Suggested change
"*": allow
"*": allow
"*credentials*": deny

Copilot uses AI. Check for mistakes.
"*.env*": deny
"*.tfvars": deny
"*.pem": deny
"*.key": deny
"*secret*": deny
glob: allow
edit:
"*": allow
Expand Down
Loading