Skip to content

23 fix format some messages bypass format mode output even though they appear in humanreadable mode #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SizzleUnrlsd merged 7 commits into from
Feb 1, 2026
Merged

23 fix format some messages bypass format mode output even though they appear in humanreadable mode #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d5923e
chore: redundant code removal
SizzleUnrlsd Feb 1, 2026
aa875ab
test: addition of a test that verifies parity between --format mode a…
SizzleUnrlsd Feb 1, 2026
43fad75
fix: format some messages bypass format mode output even though they …
SizzleUnrlsd Feb 1, 2026
c513b6e
test(alloca): adding some tests
SizzleUnrlsd Feb 1, 2026
1bd5464
test(CI-Ubuntu): try to fix CI
SizzleUnrlsd Feb 1, 2026
ce44800
test(CI-Ubuntu): try to fix CI
SizzleUnrlsd Feb 1, 2026
f5537fa
test(CI-Ubuntu): try to fix CI
SizzleUnrlsd Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 26 additions & 24 deletions main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,24 @@ static AnalysisResult filterResult(const AnalysisResult& result, const AnalysisC
return filtered;
}

static AnalysisResult filterWarningsOnly(const AnalysisResult& result, const AnalysisConfig& cfg)
{
if (!cfg.warningsOnly)
return result;

AnalysisResult filtered;
filtered.config = result.config;
filtered.functions = result.functions;
for (const auto& d : result.diagnostics)
{
if (d.severity != DiagnosticSeverity::Info)
{
filtered.diagnostics.push_back(d);
}
}
return filtered;
}

void toto(void)
{
char test[974] = "Hello";
Expand Down Expand Up @@ -529,8 +547,9 @@ int main(int argc, char** argv)
cfg.onlyFiles.empty() && cfg.onlyDirs.empty() && cfg.onlyFunctions.empty();
if (results.size() == 1)
{
const AnalysisResult filtered =
AnalysisResult filtered =
applyFilter ? filterResult(results[0].second, cfg) : results[0].second;
filtered = filterWarningsOnly(filtered, cfg);
llvm::outs() << ctrace::stack::toJson(filtered, results[0].first);
}
else
Expand All @@ -545,7 +564,8 @@ int main(int argc, char** argv)
merged.diagnostics.insert(merged.diagnostics.end(), res.diagnostics.begin(),
res.diagnostics.end());
}
const AnalysisResult filtered = applyFilter ? filterResult(merged, cfg) : merged;
AnalysisResult filtered = applyFilter ? filterResult(merged, cfg) : merged;
filtered = filterWarningsOnly(filtered, cfg);
llvm::outs() << ctrace::stack::toJson(filtered, inputFilenames);
}
return 0;
Expand All @@ -557,8 +577,9 @@ int main(int argc, char** argv)
cfg.onlyFiles.empty() && cfg.onlyDirs.empty() && cfg.onlyFunctions.empty();
if (results.size() == 1)
{
const AnalysisResult filtered =
AnalysisResult filtered =
applyFilter ? filterResult(results[0].second, cfg) : results[0].second;
filtered = filterWarningsOnly(filtered, cfg);
llvm::outs() << ctrace::stack::toSarif(filtered, results[0].first,
"coretrace-stack-analyzer", "0.1.0");
}
Expand All @@ -574,7 +595,8 @@ int main(int argc, char** argv)
merged.diagnostics.insert(merged.diagnostics.end(), res.diagnostics.begin(),
res.diagnostics.end());
}
const AnalysisResult filtered = applyFilter ? filterResult(merged, cfg) : merged;
AnalysisResult filtered = applyFilter ? filterResult(merged, cfg) : merged;
filtered = filterWarningsOnly(filtered, cfg);
llvm::outs() << ctrace::stack::toSarif(filtered, inputFilenames.front(),
"coretrace-stack-analyzer", "0.1.0");
}
Expand Down Expand Up @@ -640,35 +662,15 @@ int main(int argc, char** argv)
llvm::outs() << " max stack (including callees): " << f.maxStack << " bytes\n";
}

if (f.isRecursive)
{
llvm::outs() << " [!] recursive or mutually recursive function detected\n";
}

if (f.hasInfiniteSelfRecursion)
{
llvm::outs() << " [!!!] unconditional self recursion detected (no base case)\n";
llvm::outs() << " this will eventually overflow the stack at runtime\n";
}

if (f.exceedsLimit)
{
llvm::outs() << " [!] potential stack overflow: exceeds limit of "
<< result.config.stackLimit << " bytes\n";
}

if (!result.config.quiet)
{
for (const auto& d : result.diagnostics)
{
if (d.funcName != f.name)
continue;

// Si warningsOnly est actif, on ignore les diagnostics Info
if (result.config.warningsOnly && d.severity == DiagnosticSeverity::Info)
{
continue;
}

if (d.line != 0)
{
Expand Down
Loading
Loading