core cleanup and code refactoring #177
Open
+379
−425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Remove duplicated code in metrics module
…pace implementation. Added a small doc in the conntracker/main.rs file
LorenzoTettamanti
added
code refactoring
…ed.Improved map handlers code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a heavy module code refactoring. In particular, I moved the program handlers and map handlers to the common crate under separate features. This will reduce code duplication in the future.
The code is fully compatible with the actual latest version of the agent api
Tested with images:
lorenzotettamanti/cortexflow-metrics:0.1.2-test12
lorenzotettamanti/cortexflow-identity:0.1.5-refcount9
ghcr.io/cortexflow/agent:latest