refactor: Centralize timeout constants

[echobt]

Summary

This PR extracts hardcoded timeout values scattered across multiple modules into a centralized TimeoutConfig module in cortex-common. This improves maintainability and consistency across the codebase.

Changes

• Create src/cortex-common/src/timeout.rs with documented timeout constants
• Update cortex-exec/src/runner.rs to use centralized constants
• Update cortex-engine/src/tools/handlers/batch.rs to use centralized constants
• Export timeout module from cortex-common

Verification

cargo check -p cortex-common -p cortex-exec -p cortex-engine

[greptile-apps]

Greptile Overview

Greptile Summary

Extracted hardcoded timeout constants from multiple modules into a centralized timeout.rs module in cortex-common, improving maintainability and consistency.

Key Changes:

• Created well-documented timeout.rs with 7 timeout constants and validation tests
• Replaced DEFAULT_TIMEOUT_SECS → DEFAULT_EXEC_TIMEOUT_SECS in cortex-exec/runner.rs
• Removed duplicate DEFAULT_BATCH_TIMEOUT_SECS from cortex-engine/batch.rs
• Added cortex-common dependency to cortex-exec package
• All constants properly re-exported through module public APIs

The refactoring is clean, maintains backward compatibility through re-exports, and includes test coverage to validate timeout value relationships.

Confidence Score: 5/5

• This PR is safe to merge with no issues found
• Clean refactoring that improves code organization without changing behavior - all constants retain their original values, proper module structure with tests, and correct dependency management
• No files require special attention

Important Files Changed

Filename	Overview
src/cortex-common/src/timeout.rs	New module with well-documented timeout constants and validation tests
src/cortex-exec/src/runner.rs	Replaced local timeout constants with centralized imports from cortex-common
src/cortex-engine/src/tools/handlers/batch.rs	Removed local constant and imported from cortex-common

Sequence Diagram

sequenceDiagram
    participant Common as cortex-common/timeout
    participant Runner as cortex-exec/runner
    participant Batch as cortex-engine/batch
    participant ModExport as cortex-engine/handlers/mod

    Note over Common: Defines centralized timeout constants
    Common->>Common: DEFAULT_EXEC_TIMEOUT_SECS = 600
    Common->>Common: DEFAULT_REQUEST_TIMEOUT_SECS = 120
    Common->>Common: DEFAULT_BATCH_TIMEOUT_SECS = 300

    Note over Runner: Uses exec & request timeouts
    Runner->>Common: Import DEFAULT_EXEC_TIMEOUT_SECS
    Runner->>Common: Import DEFAULT_REQUEST_TIMEOUT_SECS
    Runner->>Runner: Set ExecOptions defaults
    Runner->>Runner: Apply timeout in run()

    Note over Batch: Uses batch timeout
    Batch->>Common: Import DEFAULT_BATCH_TIMEOUT_SECS
    Batch->>Batch: Apply timeout for parallel tool execution

    Note over ModExport: Re-exports for public API
    ModExport->>Common: Re-export DEFAULT_BATCH_TIMEOUT_SECS
    ModExport->>ModExport: Expose to external consumers

Loading

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[echobt]

Consolidated into #77 - refactor: consolidated code quality improvements - constants, lazy init, and documentation