fix(tools): add serde alias for Glob tool folder parameter #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echobt
added a commit
that referenced
this pull request
Feb 4, 2026
This PR consolidates the following tools fixes: - #53: Add serde alias for Glob tool folder parameter - #62: Align tool handler names with registration names - #63: Add serde alias for Grep tool head_limit parameter Key changes: - Added serde aliases for backward compatibility - Fixed mismatched handler names to match tool registration - Improved tool parameter handling consistency
Contributor
Author
|
Consolidated into #75 - fix(tools): consolidated tools parameter aliases and handler name fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Glob tool has a parameter naming mismatch between its definition and handler:
src/cortex-engine/src/tools/registry/definitions.rs, the Glob tool definition specifies the parameter name asfoldersrc/cortex-engine/src/tools/handlers/glob.rs, theGlobArgsstruct expects a field nameddirectoryThis mismatch can cause deserialization failures when the model sends a
folderparameter (based on the tool definition), since serde expectsdirectory.Solution
Add a serde alias attribute to the
directoryfield inGlobArgs:This allows the handler to accept both
folderanddirectoryparameter names, ensuring compatibility with the tool definition while maintaining backward compatibility with any existing code that usesdirectory.