fix: propagate error on search path canonicalization failure#69
Open
fix: propagate error on search path canonicalization failure#69
Conversation
Previously, canonicalize() failures were silently ignored, falling back to the potentially invalid or malicious path. This commit removes the silent fallback and propagates the error, ensuring that searches do not proceed with invalid paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a security issue where search path canonicalization failures were silently ignored. Previously, if
std::fs::canonicalizefailed (e.g., due to a broken symlink or non-existent path), the code fell back to using the original raw path. This could allow operations on invalid or unverified paths.Changes
src/core/search.rsto propagate the error fromstd::fs::canonicalizeinstead of suppressing it withunwrap_or_else.Verification
cargo test) to ensure no regressions.