fix: disable platform-specific features to fix clippy --all-features#70
Open
fix: disable platform-specific features to fix clippy --all-features#70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comments out platform-specific features (cuda, metal, vulkan) in Cargo.toml. These features, when enabled via
--all-features, cause build failures on environments that lack the necessary SDKs (e.g. CI, Linux without CUDA). Thellama-cpp-sys-2build script panics when required tools are missing. By removing them from the default feature set exposed toall-features, checks likecargo clippy --all-targets --all-featurescan pass on standard environments. Users who need these features can still enable them if they uncomment them, but they are not suitable for default inclusion in all-features check.