Added custom navigationBarClass support to NavigationController#1079
Merged
daniel-jonathan merged 1 commit intoCosmicMind:developmentfrom Jun 2, 2018
Conversation
Contributor
Author
|
Two other ways I can think of doing this are:
If you prefer either of those, I'll update my PR. |
Contributor
|
Hey @phlippieb , thank you for your contribution. I would go with your first option. Which I guess what you meant should look like this, but with 2-spaced indention just like other parts of the file: public override convenience init(rootViewController: UIViewController) {
self.init(rootViewController: rootViewController, navigationBarClass: NavigationBar.self)
}
public init(rootViewController: UIViewController, navigationBarClass: AnyClass?) {
super.init(navigationBarClass: navigationBarClass, toolbarClass: nil)
setViewControllers([rootViewController], animated: false)
}If @DanielDahan approves either option, You may remove the commit rebase development branch again and reapply changes and do one clean commit. To be honest, I am not sure about the second option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1074
Adds an initializer to NavigationController that takes a custom navigation bar class parameter; this parameter is simply passed to super.
This extends NavigationController with the ability to be initialized with a user-defined subclass of NavigationBar.