Skip to content

Comments

spread_model revision, suggestion of common module format#403

Merged
martinkilbinger merged 47 commits intoCosmoStat:developfrom
martinkilbinger:sm_rev
Jul 30, 2021
Merged

spread_model revision, suggestion of common module format#403
martinkilbinger merged 47 commits intoCosmoStat:developfrom
martinkilbinger:sm_rev

Conversation

@martinkilbinger
Copy link
Contributor

No description provided.

@sfarrens sfarrens changed the base branch from master to develop June 17, 2021 11:58
@sfarrens sfarrens assigned martinkilbinger and unassigned sfarrens Jun 23, 2021
@martinkilbinger
Copy link
Contributor Author

No outstanding comments from @axel left. @sfarrens should we merge this PR?

@sfarrens
Copy link
Member

sfarrens commented Jul 1, 2021

@martinkilbinger I think we should wait to merge all of the PRs at the same time. If we decide to implement some style convention it would be good for everyone to update their code accordingly. I am planning to write a comment about this soon.

@martinkilbinger martinkilbinger mentioned this pull request Jul 22, 2021
13 tasks
@martinkilbinger
Copy link
Contributor Author

Update: Code now up to new rule standards. I tested it, it works.
However, this module runs on CFIS with a config file that uses two vignet_runner calls. I need to wait for the other PR, that deals with multiple calls of the same module. So I will wait to merge this PR here.

@sfarrens
Copy link
Member

@martinkilbinger there are some conflicts that need to be resolved for this branch.

@martinkilbinger
Copy link
Contributor Author

@martinkilbinger there are some conflicts that need to be resolved for this branch.

Solved.

@martinkilbinger martinkilbinger merged commit a09af4f into CosmoStat:develop Jul 30, 2021
@martinkilbinger martinkilbinger deleted the sm_rev branch July 30, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants