vignetmaker Clean Up

[sfarrens]

Summary

• Closes [Management] Module clean up: vignetmaker_runner and vignetmaker_runner2 #409
• Module restructured according to guidelines in Modules to clean up #404

[sfarrens]

@aguinot I could only see some very minor difference between vignetmaker_runner.py and vignetmaker_runner2.py so I have based the first pass of the refactoring on vignetmaker_runner2.py, which includes sqlitedict. Is there any need to have both?

When you have time, please also send me some example input data (with appropriate config file options) I can use to test this module.

[aguinot]

I created a config file to test both way to run the vignettes_maker on CANDIDE at: /home/guinot/config_test_VM.ini
You will need to runner as you will see. I left the OUTPUT_DIR empty so you will have to pick one.
If you want to compare the output you will find them at /automnt/n17data/guinot/simu_W3/pipeline_output/run_sp_MaSxPsViSmVi_2021-03-23_18-19-08/
Let me know if encounter an issue.

[martinkilbinger]

Looks good to me.

We should discuss together:

• removal of vignetmaker_runner2. I am in favor of this, however: the reason some modules have a *RUNNER2 version is multiple calls to the same module in one config file. One solution could be to split the config file into two parts. And to assign unique run names with which subsequent module calls can refer those runs. Will require a bit of work.
• Naming convention, some previous module have capitalized package names, do we want to make this consistent?