Merge stars: MCCD#467
Merged
martinkilbinger merged 17 commits intoCosmoStat:developfrom Dec 1, 2021
martinkilbinger:merge_stars
Merged
Merge stars: MCCD#467martinkilbinger merged 17 commits intoCosmoStat:developfrom martinkilbinger:merge_stars
martinkilbinger merged 17 commits intoCosmoStat:developfrom
martinkilbinger:merge_stars
Conversation
Contributor
Author
|
Let's leave this PR open, I will add stuff for psfex. |
Contributor
Author
|
OK, for both psfex and mccd the merging of starcats is working and has been tested. @sfarrens @tobias-liaudat go ahead and have a look at the code. |
Member
tobias-liaudat
left a comment
tobias-liaudat
left a comment
There was a problem hiding this comment.
I left two comments on the documentation of two functions.
Besides that, it looks good to me, specially if you tested it and its working :)
13 tasks
sfarrens
requested changes
Oct 20, 2021
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
Co-authored-by: Samuel Farrens <samuel.farrens@gmail.com>
Contributor
Author
|
I'll merge it then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working for MCCD. The psfex version is still under development.
Partial solution for
#446