Skip to content

Bug fix(es) for v1.0.1 #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfarrens merged 6 commits into from
Oct 12, 2022
Merged

Bug fix(es) for v1.0.1 #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee5f566
Summer 2022 Patch Release v1.0.1 (#581)
sfarrens Sep 17, 2022
1b57d0d
fixed typo in variable name
martinkilbinger Oct 4, 2022
a18dfa0
config file vignet runner output fixed
martinkilbinger Oct 4, 2022
1dc0f94
typo in make_cat config ini file fixed
martinkilbinger Oct 5, 2022
f068e00
Merge remote-tracking branch 'upstream/develop' into run_fix
martinkilbinger Oct 5, 2022
da5b13e
Update shapepipe/modules/mask_package/mask.py
martinkilbinger Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ cd shapepipe

where `<VERSION>` is a
[tagged release](https://github.com/CosmoStat/shapepipe/releases) of ShapePipe
(e.g. `v1.0.0`). It is recommend to use the
(e.g. `v1.0.1`). It is recommend to use the
[latest release](https://github.com/CosmoStat/shapepipe/releases/latest)
unless you want to reproduce an older set of results.

Expand Down
2 changes: 1 addition & 1 deletion example/cfis/config_make_cat_mccd.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ FILE_EXT = .fits, .fits, .sqlite, .fits
NUMBERING_SCHEME = -000-000

SM_DO_CLASSIFICATION = True
SM_STAR_STRESH = 0.003
SM_STAR_THRESH = 0.003
SM_GAL_THRESH = 0.01

SHAPE_MEASUREMENT_TYPE = ngmix
Expand Down
4 changes: 2 additions & 2 deletions example/cfis/config_tile_MiViSmVi.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ ME_LOG_WCS = $SP_RUN/output/log_exp_headers.sqlite

[VIGNETMAKER_RUNNER_RUN_1]

# Create vignets for tiles weights
# Create vignets for tile weights

INPUT_DIR = last:sextractor_runner_run_1, last:uncompress_fits_runner

Expand Down Expand Up @@ -177,5 +177,5 @@ PREFIX =
# Additional parameters for path and file pattern corresponding to single-exposure
# run outputs
ME_IMAGE_DIR = split_exp_runner, split_exp_runner, split_exp_runner, sextractor_runner_run_2
ME_IMAGE_PATTERN = flag, image, weight, sexcat_background
ME_IMAGE_PATTERN = flag, image, weight, background
ME_LOG_WCS = $SP_RUN/output/log_exp_headers.sqlite
10 changes: 8 additions & 2 deletions shapepipe/modules/mask_package/mask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def make_mask(self):
self._config[_type]['cat_path'],
size_plus=self._config[_type]['size_plus'],
flag_value=self._config[_type]['flag'],
typ=_type,
obj_type=_type,
)

if not self._err:
Expand Down Expand Up @@ -535,7 +535,13 @@ def mask_border(self, width=100, flag_value=4):

return flag

def mask_dso(self, cat_path, size_plus=0.1, flag_value=8, typ='Messier'):
def mask_dso(
self,
cat_path,
size_plus=0.1,
flag_value=8,
obj_type='Messier',
):
"""Mask DSO.

Create a circular patch for deep-sky objects (DSOs), e.g.
Expand Down