run_cosmo_val: save results, summarize_bmodes, snakemake rule#184
Merged
martinkilbinger merged 3 commits intodevelopfrom Feb 23, 2026
Merged
run_cosmo_val: save results, summarize_bmodes, snakemake rule#184martinkilbinger merged 3 commits intodevelopfrom
martinkilbinger merged 3 commits intodevelopfrom
Conversation
…g fixes - Add save_pure_eb_results/save_cosebis_results to b_modes.py - Add summarize_bmodes() summary table to CosmologyValidation - Store _pure_eb_results/_cosebis_results on instance for summarize_bmodes - Fix cc[ver]['shear']['mask'] → cc[ver]['mask'] (mask at top level in cat_config) - Fix self.data_base_dir + redshift_distr → cc[ver]['shear']['redshift_path'] - Comment out plot_objectwise_leakage_aux() (method doesn't exist) - Comment out calculate_pseudo_cl_g_ng_cov() (OneCovariance needs hmf, not in container) - Add explicit scale_cuts param to calculate_cosebis/plot_cosebis - claims.smk: filter _ecut from VERSIONS_LEAK_CORR, add explicit versions params Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cailmdaley
force-pushed
the
feature/run-cosmo-val-improvements
branch
from
8562702 to
be323a0
Compare
Collaborator
Author
|
Note: these changes are already on |
"6.3" contains a dot — would produce invalid TeX macro names like \configPte6.3Xip. Add "6.3" → "SixThree" to the version mapping. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
martinkilbinger
requested changes
Feb 23, 2026
Contributor
martinkilbinger
left a comment
martinkilbinger
left a comment
There was a problem hiding this comment.
Looking good, but there are conflicts, could you please fix them?
Take develop's refactored versions throughout: - b_modes.py: use _EB_KEYS loop, _cosebis_result_to_dict helper, cleaner is_multi pattern in save_cosebis_results - cosmo_val.py: loop over stats tuple, has_multi_scale_cuts variable, col_labels dict, compact row-printing in summarize_bmodes - run_cosmo_val.py: use FIDUCIAL_SCALE_CUT constant, max_sep_int=300, %% section comments Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
oops missed that! should be good now @martinkilbinger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summarize_bmodes()— new method onCosmologyValidationthat prints a per-version PTE table across all five statistics (ξ+B, ξ−B, Combined, COSEBIs, C_ℓBB) at a configurable fiducial scale cutsave_pure_eb_results()/save_cosebis_results()— save B-mode results to.npzfor downstream use_pure_eb_results/_cosebis_resultsstored on the instance sosummarize_bmodes()can aggregate across statistics without recomputationcc[ver]['mask']top-level key (notshear.mask),cc[ver]['shear']['redshift_path'](notredshift_distr),npatch→npatch1for scalar patch countExample output
From a UNIONS run over two catalog versions (SP_v1.4.6 and SP_v1.4.11.3):
🤖 Generated with Claude Code