Add output readback#8
Conversation
There was a problem hiding this comment.
I finally found some time to look at this. Thanks for posting it! I haven't tested it yet because I need to set up the PLC first. But at a glance, the PR looks nice. I always appreciate it when people take time to update the docs and examples together with the code 😄. There are two things that occurred to me while reading the code, addressed in separate comments.
|
Looks good to me. Many thanks! Testing took a while because it exposed unrelated issues, some of them seem to be in asyn: it looks like I took the opportunity to make a small tweak and remove a bit of deprecated code. I will rebase and squash, hopefully tomorrow. |
The write variables marked for readback are added to the sum-read list.
This bug started to manifest after the asyn:READBACK changes.
This PR will introduce the following changes:
Operation::ReadWritewithRWin the asynUser textOperation::ReadWriteto both listsads_read_varsandads_write_varsinfo(asyn:READBACK, "1")by allow to write only if ads is connectedADSVariable. Until the written value is read back, the written value will be returned.The new
Operation::ReadWriteshould not interfere with existing configurations. I have successfully tested the readback with all scalar and array datatypes.Closes #6