bugfix/localization-updates#197
Merged
BrianL3 merged 2 commits intoCouncilDataProject:mainfrom Feb 12, 2022
Merged
Conversation
evamaxfield
approved these changes
Feb 10, 2022
Member
evamaxfield
left a comment
evamaxfield
left a comment
There was a problem hiding this comment.
Still need to roll out the localization feature 😂
Looks good tho
Collaborator
|
Looks good, but let's keep the gh-issue open and update it if there's any text that still needs translating and added to the localization feature? |
tohuynh
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #183
Changes
Adding many new strings to the localized files. We do not yet have a firm idea on placement of the localization widget. However, getting strings localized as we go will be of great help when we finally do add the widget.