-
Notifications
You must be signed in to change notification settings - Fork 983
[SER-2653] Fix rating export #7291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the star-rating “rating” value shown/exported by moving the + 1 adjustment from the template into the data preparation step, and aligning the rating color classes accordingly.
Changes:
- Adjust ratings table display to use the prepared
ratingvalue directly (no inline+ 1). - Shift
.rating-color-*styles from0-4to1-5. - Increment
ratinginpreparedRowsso exported/displayed data uses 1-based ratings.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/star-rating/frontend/public/templates/ratings-table.html | Stops adding + 1 in the template so rating comes from prepared row data. |
| plugins/star-rating/frontend/public/stylesheets/ratings.scss | Renames rating color classes to match 1-based rating values. |
| plugins/star-rating/frontend/public/javascripts/countly.views.js | Adjusts preparedRows to increment rating values for display/export. |
| CHANGELOG.md | Documents the star-rating export fix. |
plugins/star-rating/frontend/public/javascripts/countly.views.js
Outdated
Show resolved
Hide resolved
f6bd7e5 to
78e45e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
plugins/star-rating/frontend/public/javascripts/countly.views.js
Outdated
Show resolved
Hide resolved
78e45e3 to
44c5dbd
Compare
44c5dbd to
ea3aba9
Compare
No description provided.