Skip to content

Remove loading overlay and add SonarCloud badges #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opott merged 2 commits into from
Jul 19, 2025
Merged

Remove loading overlay and add SonarCloud badges #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c31057
refactor: remove loading overlay and related includes from layout files
opott Jul 19, 2025
c55314a
feat: sonarcloud badges
opott Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
<p><img src="img/inverted_banner.svg" style="width: 500px"></p>

[![Quality gate](https://sonarcloud.io/api/project_badges/quality_gate?project=CourseNotes_site)](https://sonarcloud.io/summary/new_code?id=CourseNotes_site)
[![Bugs](https://sonarcloud.io/api/project_badges/measure?project=CourseNotes_site&metric=bugs)](https://sonarcloud.io/summary/new_code?id=CourseNotes_site)
[![Vulnerabilities](https://sonarcloud.io/api/project_badges/measure?project=CourseNotes_site&metric=vulnerabilities)](https://sonarcloud.io/summary/new_code?id=CourseNotes_site)
[![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=CourseNotes_site&metric=reliability_rating)](https://sonarcloud.io/summary/new_code?id=CourseNotes_site)
[![Security Rating](https://sonarcloud.io/api/project_badges/measure?project=CourseNotes_site&metric=security_rating)](https://sonarcloud.io/summary/new_code?id=CourseNotes_site)
[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=CourseNotes_site&metric=sqale_rating)](https://sonarcloud.io/summary/new_code?id=CourseNotes_site)
[![Technical Debt](https://sonarcloud.io/api/project_badges/measure?project=CourseNotes_site&metric=sqale_index)](https://sonarcloud.io/summary/new_code?id=CourseNotes_site)

---

Revision Made Simple
Expand Down
15 changes: 5 additions & 10 deletions _includes/head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
<head>
<title>{{ page.title }} | CourseNotes</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="/assets/style.css" />
<link rel="icon" type="image/x-icon" href="/img/Favicon.ico" />
<script>
window.addEventListener("load", function () {
document.querySelector(".loading-overlay").style.display = "none";
});
</script>
</head>
<title>{{ page.title }} | CourseNotes</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="/assets/style.css" />
<link rel="icon" type="image/x-icon" href="/img/Favicon.ico" />
</head>
3 changes: 0 additions & 3 deletions _includes/loading.html
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion _layouts/course_home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<html>
{% include head.html %}
<body>
{% include header.html %} {% include loading.html %}
{% include header.html %}
<div class="hero" style="height: 20rem">
<div class="hero-content">
<h1>{{ page.course_title }}</h1>
Expand Down
2 changes: 1 addition & 1 deletion _layouts/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<html>
{% include head.html %}
<body>
{% include header.html %} {% include loading.html %}
{% include header.html %}
<div class="hero">
<div class="hero-content">
<h1>{{ page.hero_title }}</h1>
Expand Down
5 changes: 1 addition & 4 deletions _layouts/page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,12 @@
{% include head.html %}
<body>
{% include header.html %}
{% include loading.html %}
<div class="hero" style="height: 20rem">
<div class="hero-content">
<h1>{{ page.hero_title }}</h1>
<p>{{ page.hero_subtitle }}</p>
</div>
</div>
{{ content }}
{% include tawk.html %}
{% include footer.html %}
{{ content }} {% include tawk.html %} {% include footer.html %}
</body>
</html>