This repository was archived by the owner on Sep 25, 2019. It is now read-only.
Hiepluong dev request#63
Closed
hiepluonghlv wants to merge 5 commits intoCoursemology:developmentfrom
Closed
Conversation
validation for empty name, drag drop pos, separated display student level and achievement
Contributor
|
@raymondtangsc Has this been checked and merged? |
Contributor
|
@hiepluonghlv , this is not good. Please look at the comments I had before and improve. Though you added order by drag and drop, but the issues I mentioned are not resolved. |
hiepluonghlv
added a commit
to hiepluonghlv/coursemology.org
that referenced
this pull request
Aug 14, 2014
edit name, edit display/hide for students, remove items, add items and "Levels and Achievement" using ajax; drag & drop for ordering; fixed Coursemology#61 and Coursemology#63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional improvements for sidebar task: