-
Notifications
You must be signed in to change notification settings - Fork 78
React Migration: Dynamic Nest API, course sidebar, breadcrumbs #6100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
5d28b25
chore(react): add react-refresh for Fast Refresh
pchunky 64d7202
refactor(announcements): correctly type `AnnouncementListData`
pchunky c4322d9
feat(announcements): add `unread` global announcements
pchunky cd0c4a8
refactor(constants): add icons for all course components
pchunky c708165
style(sidebar): use standard icons, fix missing item keys
pchunky 9afc7eb
chore(eslint): disable `import/prefer-default-export`
pchunky 7e3750a
style(fonts): replace Roboto with Inter
pchunky 50e7320
style(tailwind): move colour slots to its plugin definition
pchunky d04e29e
feat(tailwind): add `bg-fade-to-r`
pchunky f80d665
feat(tailwind): add instant borders plugin
pchunky 2e46e54
feat(tailwind): add primary colour
pchunky 58e61dd
style: remove persistent custom scrollbar
pchunky f16a325
refactor(AssessmentsTable): make `StackedBadges` reusable
pchunky 8111b95
feat(AssessmentsTable): disable flying action buttons
pchunky bfed8af
feat(SearchField): make autofocus work
pchunky 1d43d67
feat(SearchField): add `noIcon` prop
pchunky 872c08b
refactor: ProviderWrapper -> Providers
pchunky e83379e
chore(deps-dev): bump react-router-dom from 6.3.0 to 6.11.1 in /client
pchunky 761d4fe
feat(courses): add `/sidebar` endpoint
pchunky 4529fe4
feat: add endpoint to fetch home data
pchunky a026a8b
style(Section): sticks to top 0px of page
pchunky 642cef8
style(DataTable): remove elevation
pchunky b8e564f
feat(router): add Dynamic Nest API
pchunky 0db886c
feat(app): add `AppContainer`
pchunky 7146112
feat(courses): add `CourseContainer`
pchunky 7f78bc0
feat(components): add `Page`, deprecate `PageHeader`
pchunky daffaf0
feat(courses): render string url to course logo
pchunky 28b8e6f
feat(app): migrate to new router, combine bundles
pchunky 55dfb20
refactor(admin): remove sidebar, breadcrumbs from admin pages
pchunky 5cf7e87
style(controller_helper): remove unused `display_course_user_badge`
pchunky ab0c29c
style(controller_helper): remove unused `display_course_logo`
pchunky 15b4807
fix(usePrompt): `navigation.block` removed in react-router-dom 6.4.0
pchunky 6ffbcc0
fix(table): cannot type space in search field in prod
pchunky 4b7d266
feat(Footer): add correct copyright build years
pchunky 597fbc3
feat(Footer): add correct links to external pages
pchunky 5e3af60
style(DescriptionCard): extract translation, flatten borders
pchunky d71e0bf
refactor(admin): clean up system, instance admin components
pchunky bff1142
feat: migrate more pages to `Page`, fix margin issues
pchunky 97e1c13
fix(PopupNotifier): suppress error on 403 when fetching
pchunky 18cf8fd
fix(AssessmentSessionNew): the `div` doesn't scroll with page
pchunky 6b5e246
test: fix all sidebar tests
pchunky 1c9c12d
test(requests): remove redundant devise_pages_spec
pchunky 0662939
test(requests): remove redundant high_voltage_pages_spec
pchunky 58ed73e
test(log): fix session token not cleared after logout-login
pchunky f4b4814
test(profile_edit): fix flaky tests
pchunky 7b64612
test(global_announcements): test against announcement content
pchunky e32201b
test(course_management): test against course titles
pchunky 5c297d3
test(system/admin): do not use xpath
pchunky 07a8891
test(multiple_response_answer): do not use xpath
pchunky 17291d6
test(system/admin): test against announcement contents
pchunky 8fe63ea
test(announcements): test against announcement contents
pchunky 5c6cb86
test(programming_management): select proper case buttons
pchunky 95a26b7
test(manually_graded): select proper case button
pchunky 0781602
test(homepage): select proper case button
pchunky e4d689a
test(skill_management): select Skill button by caption
pchunky e4df158
test(multiple_response_management): select delete button by aria-label
pchunky e76efa1
test(text_response_management): select delete button by aria-label
pchunky 1e817d8
test(course): announcements header now shows only when not empty
pchunky 45218bb
test(factories): fix non-unique assessment tabs cannot be selected
pchunky 7143569
test(course/user_profile): no more manage email subscriptions links
pchunky e0f1c27
feat(layouts): separate renders for react and static pages
pchunky adb1532
style(layouts): remove unused sidebar, course layouts
pchunky e7fe17b
style(views): remove breadcrumbs
pchunky 2f4515c
style(controllers): remove breadcrumbs
pchunky e239b74
style(locales): remove unused translations
pchunky 22f0fc9
style(components): remove deprecated `PageHeader`
pchunky a24cc9f
feat(CourseContainer): always scroll up when location changes
pchunky 9e0b166
feat(Link): support routing with `to`
pchunky b506037
feat: replace all anchors `<a .../>` with `Link`
pchunky a3ed243
feat(Link): support `ref` assignment
pchunky 357a8e0
feat: replace all React Router's `Link` with our `Link`
pchunky 6409b10
feat: replace remaining `Link`s with our `Link`
pchunky a27e6cc
test(SubmissionsTable): new `Link` requires `BrowserRouter` context
pchunky 2bcb33b
test(admin): links are no longer `button`s
pchunky 19e8144
test(course_management): fix sometimes cannot find `active_course`
pchunky 1d20dc8
feat(Footer): add latest build time, commit head SHA
pchunky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
app/assets/stylesheets/course/dangerously-fit-height-to-viewport.scss
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
app/controllers/course/admin/announcement_settings_controller.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
app/controllers/course/admin/assessment_settings_controller.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
app/controllers/course/admin/discussion/topic_settings_controller.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
app/controllers/course/admin/leaderboard_settings_controller.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
app/controllers/course/admin/lesson_plan_settings_controller.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.