Migrate to react-dynamic-breadcrumbs#7856
Merged
Merged
Conversation
pchunky
added
Enhancement
Dependencies
cysjonathan
approved these changes
Mar 21, 2025
pchunky
force-pushed
the
phillmont/react-dynamic-breadcrumbs
branch
from
3ed5ff1 to
32caca7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates our breadcrumbs to react-dynamic-breadcrumbs. It is spec-compliant with the Dynamic Nest API first introduced in #6100, with minor enhancements, proper API documentation, and unit tests.
I might also introduce page title support in react-dynamic-breadcrumbs, to which Coursemology will just get that feature for free. Using a shared library means we can share this amazing system with others, benefit from less need for maintenance and feature isolation.