Merged
Conversation
MathisGredt
approved these changes
May 24, 2025
- Added @SuppressWarnings and @ParametersAreNonnullByDefault annotations to several classes for better code clarity. - Renamed variables for consistency and clarity in ClothItem and ReactorBluePrintItem. - Simplified conditional checks in CNFanProcessingTypes and ReactorControllerBlock. - Removed unused ReactorOption enum and cleaned up ReactorCasingEntity. - Improved overlay rendering logic in CNClientEvent and added new IrradiatedOverlayRendererVision class. - Commented out unused RadiationOverlay in HudRenderer. - Enhanced readability by reducing nested conditions and using early returns where applicable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files, primarily focusing on improving code consistency, simplifying tag usage, and cleaning up unused imports. Below is a summary of the most important changes grouped by theme:
Tag Refactoring and Consistency:
CNBlockTags.NEEDS_DIAMOND_TOOLandCNBlockTags.NEEDS_IRON_TOOLtags with standardBlockTags.NEEDS_DIAMOND_TOOLandBlockTags.NEEDS_IRON_TOOLinCNBlocks.javato align with standard conventions. [1] [2] [3]Code Cleanup:
CNPotions.java,CNCreativeModeTabs.java, andCNBlocks.java, to reduce clutter and improve readability. [1] [2] [3].propertiescalls into a single chained call forENRICHING_CAMPFIREinCNBlocks.javato simplify block property definitions.Naming and Variable Improvements:
CNPOTIONStoCN_POTIONSinCNPotions.javafor improved naming consistency.CNCreativeModeTabs.javato improve clarity (e.g.,pOutptopOuts).Suppressions and Annotations:
@SuppressWarningsannotations inCNDamageTypes.javaandCNItems.javato suppress warnings about unused and deprecated elements, improving code maintainability. [1] [2]Minor Adjustments:
These changes collectively improve the codebase's maintainability, readability, and adherence to conventions.