Skip to content

Debug hud radiation#53

Merged
Giovanniricotta2002 merged 3 commits intomainfrom
debug-HudRadiation
May 24, 2025
Merged

Debug hud radiation#53
Giovanniricotta2002 merged 3 commits intomainfrom
debug-HudRadiation

Conversation

@Giovanniricotta2002
Copy link
Member

@Giovanniricotta2002 Giovanniricotta2002 commented May 24, 2025

This pull request includes several changes across multiple files, primarily focusing on improving code consistency, simplifying tag usage, and cleaning up unused imports. Below is a summary of the most important changes grouped by theme:

Tag Refactoring and Consistency:

  • Replaced custom CNBlockTags.NEEDS_DIAMOND_TOOL and CNBlockTags.NEEDS_IRON_TOOL tags with standard BlockTags.NEEDS_DIAMOND_TOOL and BlockTags.NEEDS_IRON_TOOL in CNBlocks.java to align with standard conventions. [1] [2] [3]
  • Updated item and block tags for enriched and uranium-related blocks to ensure proper categorization and compatibility with Forge tags. [1] [2] [3]

Code Cleanup:

  • Removed unused imports from several files, including CNPotions.java, CNCreativeModeTabs.java, and CNBlocks.java, to reduce clutter and improve readability. [1] [2] [3]
  • Consolidated multiple .properties calls into a single chained call for ENRICHING_CAMPFIRE in CNBlocks.java to simplify block property definitions.

Naming and Variable Improvements:

  • Renamed CNPOTIONS to CN_POTIONS in CNPotions.java for improved naming consistency.
  • Adjusted variable names in CNCreativeModeTabs.java to improve clarity (e.g., pOutp to pOuts).

Suppressions and Annotations:

  • Added @SuppressWarnings annotations in CNDamageTypes.java and CNItems.java to suppress warnings about unused and deprecated elements, improving code maintainability. [1] [2]

Minor Adjustments:

  • Fixed formatting issues and removed unnecessary blank lines across multiple files, improving code readability. [1] [2]

These changes collectively improve the codebase's maintainability, readability, and adherence to conventions.

- Added @SuppressWarnings and @ParametersAreNonnullByDefault annotations to several classes for better code clarity.
- Renamed variables for consistency and clarity in ClothItem and ReactorBluePrintItem.
- Simplified conditional checks in CNFanProcessingTypes and ReactorControllerBlock.
- Removed unused ReactorOption enum and cleaned up ReactorCasingEntity.
- Improved overlay rendering logic in CNClientEvent and added new IrradiatedOverlayRendererVision class.
- Commented out unused RadiationOverlay in HudRenderer.
- Enhanced readability by reducing nested conditions and using early returns where applicable.
@Giovanniricotta2002 Giovanniricotta2002 merged commit a316be5 into main May 24, 2025
@Giovanniricotta2002 Giovanniricotta2002 deleted the debug-HudRadiation branch May 24, 2025 15:28
@Giovanniricotta2002 Giovanniricotta2002 restored the debug-HudRadiation branch May 24, 2025 15:32
@Giovanniricotta2002 Giovanniricotta2002 deleted the debug-HudRadiation branch May 24, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants