Refactor item validation in ReactorInputInventory to use CNTags for better maintainability#63
Merged
MathisGredt merged 1 commit intomainfrom Sep 21, 2025
Merged
Conversation
…etter maintainability
MathisGredt
approved these changes
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the codebase to replace hardcoded item checks with tag-based checks, improving flexibility and maintainability. Additionally, wildcard imports were introduced in one file. The most important changes are summarized below:
Refactoring to use tag-based item checks:
calculateHeatinReactorControllerBlockEntityto replace hardcoded item ID checks ("createnuclear:uranium_rod"and"createnuclear:graphite_rod") with checks usingCNTags.CNItemTags.FUEL.tagandCNTags.CNItemTags.COOLER.tag. This change applies to both the main loop and proximity heat calculations. [1] [2]isItemValidinReactorInputInventoryto useCNTags.CNItemTags.FUEL.matchesandCNTags.CNItemTags.COOLER.matchesinstead of directly comparing items toCNItems.URANIUM_RODandCNItems.GRAPHITE_ROD.Import changes:
import net.nuclearteam.createnuclear.*) inReactorControllerBlockEntity. This reduces verbosity but may introduce unnecessary imports.CNTagsimport inReactorInputInventoryto support the tag-based checks.