Skip to content

Test output#79

Merged
MathisGredt merged 8 commits intomainfrom
testOutput
Nov 22, 2025
Merged

Test output#79
MathisGredt merged 8 commits intomainfrom
testOutput

Conversation

@MathisGredt
Copy link
Collaborator

This pull request introduces significant changes to the ReactorOutputEntity class, primarily refactoring how the generated speed is handled and persisted, and makes a minor fix to a mixin method name. The main focus is on removing the ScrollValueBehaviour for speed control and replacing it with a simpler float-based approach, including proper NBT serialization. Additionally, a method name in a mixin is corrected for compatibility.

Reactor Output Entity Refactor

  • Removed the ScrollValueBehaviour-based speed control and replaced it with a direct float generatedSpeed field, simplifying speed management and removing unused dependencies.
  • Added NBT serialization for the generatedSpeed field by overriding the read and write methods, ensuring the speed persists across world saves and loads.
  • Implemented a new method determineSpeed() and refactored speed updating logic to use the new generatedSpeed approach.
  • Updated getGeneratedSpeed() to clamp the returned speed between 0 and 1,500,000 using Mth.clamp, improving safety and consistency.

Mixin Fix

  • Fixed the method name in the BaseFireBlockMixin's @Inject annotation from the obfuscated m_49245_ to the actual getState, improving code clarity and compatibility.

@MathisGredt MathisGredt merged commit 9fc5b31 into main Nov 22, 2025
@Giovanniricotta2002 Giovanniricotta2002 deleted the testOutput branch December 28, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants