Merged
Conversation
…emplace Math.clamp par Mth.clamp pour le calcul de la vitesse générée
…d pour améliorer la clarté du code
…s références de méthode
…State pour améliorer la lisibilité du code
… en ajoutant des points-virgules manquants et en nettoyant les importations inutilisées.
…our améliorer la lisibilité du code
Giovanniricotta2002
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the
ReactorOutputEntityclass, primarily refactoring how the generated speed is handled and persisted, and makes a minor fix to a mixin method name. The main focus is on removing theScrollValueBehaviourfor speed control and replacing it with a simpler float-based approach, including proper NBT serialization. Additionally, a method name in a mixin is corrected for compatibility.Reactor Output Entity Refactor
ScrollValueBehaviour-based speed control and replaced it with a directfloat generatedSpeedfield, simplifying speed management and removing unused dependencies.generatedSpeedfield by overriding thereadandwritemethods, ensuring the speed persists across world saves and loads.determineSpeed()and refactored speed updating logic to use the newgeneratedSpeedapproach.getGeneratedSpeed()to clamp the returned speed between 0 and 1,500,000 usingMth.clamp, improving safety and consistency.Mixin Fix
BaseFireBlockMixin's@Injectannotation from the obfuscatedm_49245_to the actualgetState, improving code clarity and compatibility.