Skip to content

An iOS hack should only exist on iOS #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lannymcnie merged 2 commits into from
Jan 31, 2017
Merged

An iOS hack should only exist on iOS #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa95123
An iOS hack should only exist on iOS
NuclearCookie Jan 25, 2017
6ce1ebe
Fixed case of folder to correctly build with grunt on case sensitive OS
NuclearCookie Jan 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions build/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

"../src/createjs/utils/extend.js",
"../src/createjs/utils/promote.js",
"../src/createjs/utils/IndexOf.js",
"../src/createjs/utils/Proxy.js",
"../src/createjs/utils/indexOf.js",
"../src/createjs/utils/proxy.js",
"../src/createjs/utils/BrowserDetect.js",
"../src/createjs/events/EventDispatcher.js",
"../src/createjs/events/Event.js",

"../src/createjs/events/ErrorEvent.js",

"../src/preloadjs/events/ProgressEvent.js",
"../src/preloadjs/data/LoadItem.js",
"../src/preloadjs/data/Methods.js",
Expand All @@ -32,9 +32,9 @@
"../src/soundjs/Sound.js",
"../src/soundjs/AbstractSoundInstance.js",
"../src/soundjs/AbstractPlugin.js",
"../src/soundjs/webAudio/WebAudioLoader.js",
"../src/soundjs/webAudio/WebAudioSoundInstance.js",
"../src/soundjs/webAudio/WebAudioPlugin.js",
"../src/soundjs/webaudio/WebAudioLoader.js",
"../src/soundjs/webaudio/WebAudioSoundInstance.js",
"../src/soundjs/webaudio/WebAudioPlugin.js",
"../src/soundjs/htmlaudio/HTMLAudioTagPool.js",
"../src/soundjs/htmlaudio/HTMLAudioSoundInstance.js",
"../src/soundjs/htmlaudio/HTMLAudioPlugin.js"
Expand Down
4 changes: 3 additions & 1 deletion src/soundjs/webaudio/WebAudioSoundInstance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,9 @@ this.createjs = this.createjs || {};
audioNode.disconnect(0);
// necessary to prevent leak on iOS Safari 7-9. will throw in almost all other
// browser implementations.
try { audioNode.buffer = s._scratchBuffer; } catch(e) {}
if ( createjs.BrowserDetect.isIOS ) {
try { audioNode.buffer = s._scratchBuffer; } catch(e) {}
}
audioNode = null;
}
return audioNode;
Expand Down