Fix duplicate query string keys lost during redirect cycle#17
Merged
Merged
Conversation
queryStringParse now stores duplicate keys as arrays and the reconstruction loop expands them back into separate key=value pairs, matching the fix already applied in the Akamai integration. Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Cloudflare Worker’s querystring parsing/reconstruction so duplicate query keys survive a redirect cycle (aligning behavior with the Akamai integration mentioned in the PR description).
Changes:
- Update
helpers.queryStringParseto store duplicate query keys as arrays. - Update querystring reconstruction in
handleRequestto expand array values back into repeatedkey=valuepairs. - Refresh committed build artifacts in
dist/to reflect the source changes.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| index.js | Rebuilds querystring from parsed object, expanding duplicate-key arrays into repeated pairs. |
| helpers/misc.js | Parses querystrings into an object that preserves duplicates as arrays. |
| dist/index.js | Compiled output reflecting the query parsing and reconstruction changes. |
| dist/index.js.map | Updated sourcemap for the compiled worker bundle. |
| dist/README.md | Updates the build timestamp metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queryStringParse now stores duplicate keys as arrays and the reconstruction loop expands them back into separate key=value pairs, matching the fix already applied in the Akamai integration.