Interactive reminder chip to the base note cards#828
Conversation
Updated the base note to display the most relevant reminder. Added visual differences for elapsed reminders on the base note: strikethrough text, 50% opacity.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds a clickable ReminderChip: ViewHolder renders next reminder and exposes click/long-click, ItemListener gains onReminderClick, NotallyFragment handles reminder clicks (toggles selection in action mode or launches RemindersActivity), and layout replaces the old RemindersView with a Material Chip. Changes
Sequence DiagramsequenceDiagram
actor User
participant VH as BaseNoteVH
participant Frag as NotallyFragment
participant Activity as RemindersActivity
User->>VH: tap ReminderChip
VH->>Frag: onReminderClick(position)
Frag->>Frag: check action mode
alt not in action mode
Frag->>Activity: start RemindersActivity(noteId)
Activity->>User: display reminders for note
else in action mode
Frag->>Frag: toggle/select item
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@app/src/main/java/com/philkes/notallyx/presentation/view/main/BaseNoteVH.kt`:
- Around line 405-425: In setupReminderChip (BaseNoteVH), clear the
STRIKE_THRU_TEXT_FLAG when the reminder is not elapsed so recycled ViewHolders
don't keep the strike-through: replace the current paintFlags assignment inside
binding.ReminderChip with a conditional that sets paintFlags = paintFlags or
Paint.STRIKE_THRU_TEXT_FLAG when isElapsed is true, otherwise clears it with
paintFlags = paintFlags and Paint.STRIKE_THRU_TEXT_FLAG.inv(); keep the alpha
logic as-is and ensure this change is applied on binding.ReminderChip within
setupReminderChip.
In `@app/src/main/res/layout/recycler_base_note.xml`:
- Around line 76-91: Set the Chip with id ReminderChip to default visibility
GONE in XML so it doesn't flicker before bind() runs, and update its horizontal
marginStart from 10dp to 16dp to match sibling padding; locate the Chip element
with android:id="@+id/ReminderChip" in recycler_base_note.xml and make these two
attribute changes to align with how setupReminderChip toggles visibility at bind
time.
app/src/main/java/com/philkes/notallyx/presentation/view/main/BaseNoteVH.kt
Show resolved
Hide resolved
Tools namespace to show reminder chip in Layout Editor.
|
Hi @ulibte, thanks so much for your contribution
If you are ok with these small adjustments, I'll be happy to merge this 🙂 |
|
Looks great, just one thing, Android Studio is reporting this lint error: android:paddingVertical requires API level 26 (current min is 21) here: |
Fixed and merged, thanks 🙂 |
Hey, not sure what happened exactly, probably the fault is on my part with some rebase or something. |
Related Issue: #829
Interactive reminder chip to the base note cards
Added onReminderClick to open reminder settings from the base note.
Updated the base note to display the most relevant reminder.
Added visual differences for elapsed reminders on the base note: strikethrough text, 50% opacity.
2026-02-07.03-05-15.mp4
Summary by CodeRabbit
New Features
Refactor
Style