Show notes contents in notification and use stack icon#960
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdated date/time pickers to set explicit input modes, enhanced reminder notifications to show full note content (including list items with checkbox indicators) and add notification grouping with a summary, added a new vector drawable, and removed a debug log statement. Changes
Sequence Diagram(s)sequenceDiagram
participant Receiver as ReminderReceiver
participant Manager as NotificationManager
participant System as SystemUI
Receiver->>Manager: build per-reminder Notification (title, contentText, BigTextStyle)\n.setGroup(GROUP_REMINDERS)
Manager->>System: notify(reminderId, notification)
Receiver->>Manager: build group summary Notification (setGroupSummary(true))
Manager->>System: notify(SUMMARY_ID, summaryNotification)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@app/src/main/java/com/philkes/notallyx/presentation/activity/note/reminders/ReminderReceiver.kt`:
- Around line 98-110: contentText and bigText are being built identically for
LIST notes so collapsed notifications show the full list; update the logic in
ReminderReceiver (the contentText and bigText construction for note.type ==
com.philkes.notallyx.data.model.Type.LIST) so contentText produces a short
preview (e.g., first 1–3 items or a truncated single-line summary from
note.items) while bigText remains the full join of all items, and apply the same
change to the other identical occurrence that constructs contentText/bigText for
LIST notes.
- Around line 126-131: The summary notification (summaryNotification built with
NotificationCompat.Builder, GROUP_REMINDERS) is posted unconditionally; change
logic in ReminderReceiver to first query the NotificationManager for active
notifications, count how many active child notifications belong to
GROUP_REMINDERS (exclude any existing group summary), and only post
summaryNotification when that count is > 1; otherwise cancel the group summary
(use notificationManager.cancel(...) with your group-summary notification id) to
avoid showing the stacked indicator. Apply the same conditional gating where the
summary is posted in the other occurrence as well.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c3e79710-5c51-49d2-b7fe-45d5e6deab58
📒 Files selected for processing (5)
app/src/main/java/com/philkes/notallyx/presentation/activity/note/reminders/DatePickerFragment.ktapp/src/main/java/com/philkes/notallyx/presentation/activity/note/reminders/ReminderReceiver.ktapp/src/main/java/com/philkes/notallyx/presentation/activity/note/reminders/TimePickerFragment.ktapp/src/main/java/com/philkes/notallyx/utils/changehistory/ChangeHistory.ktapp/src/main/res/drawable/notebook_multiple.xml
💤 Files with no reviewable changes (1)
- app/src/main/java/com/philkes/notallyx/utils/changehistory/ChangeHistory.kt
app/src/main/java/com/philkes/notallyx/presentation/activity/note/reminders/ReminderReceiver.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/philkes/notallyx/presentation/activity/note/reminders/ReminderReceiver.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #610
Closes #873
Also enforces to initialize Time Picker in clock mode, relates to #945
Summary by CodeRabbit
New Features
Bug Fixes
Chores