Fix peerDependencies for npm@7 and typings #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently :
"^0.41.2"because npm@7 fails if peerDependencies are not met ;This PR does the following changes:
react-nativepeerDependency to"react-native": "*";encodingargument and include the 2 other signatures (withBufferandstringI/O);@types/nodeas a dependency to importBuffertype (which seems to be the best practice for exposing typings);lockfileVersion: 2with npm@7, which now includes peerDependencies (hence its dramatic lengthening);@ggozad tell me if you want me to change something in the way the outlined issues are solved :)