Skip to content

Conversation

@tex0l
Copy link
Contributor

@tex0l tex0l commented Mar 18, 2021

Currently :

This PR does the following changes:

  • the react-native peerDependency to "react-native": "*";
  • the typings to update it with the encoding argument and include the 2 other signatures (with Buffer and string I/O);
  • import @types/node as a dependency to import Buffer type (which seems to be the best practice for exposing typings);
  • as a side effect, the package-lock.json was updated to use the lockfileVersion: 2 with npm@7, which now includes peerDependencies (hence its dramatic lengthening);
  • update the yarn.lock of the example project;
  • the CHANGELOG.

@ggozad tell me if you want me to change something in the way the outlined issues are solved :)

@ggozad ggozad merged commit a44423f into Crypho:master Mar 19, 2021
@ggozad
Copy link
Contributor

ggozad commented Mar 19, 2021

Thanks :)

@tex0l
Copy link
Contributor Author

tex0l commented Mar 19, 2021

You're welcome :), thank you for the quick merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants