Skip to content

Conversation

@aminaz
Copy link

@aminaz aminaz commented Mar 25, 2025

Github Action publish workflow runs on release tags so the check in the existing Makefile.js to ensure that you are on master is not relevant when running CI/CD from GHA. Added a check skip the branch check when running on GH as the default environment variables define GITHUB_ACTIONS to indicate that it is running in CI.

@aminaz aminaz force-pushed the fix-skip-branch-check-on-gha branch from 7b8ca4e to 7c6f8f9 Compare March 25, 2025 04:25
@aminaz aminaz merged commit ab3d785 into master Mar 25, 2025
@aminaz aminaz deleted the fix-skip-branch-check-on-gha branch March 25, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants