Merged
Conversation
There were 2 issues to address, 1 with reading and 1 with writing. Reading: if the offset needed to be moved (due to a negative value in the strengths array), the current position of the offset nor the position of the bounds were taken into account. Writing: if the very first value was not at the starting position of the heatmap, it would incorrectly move this value one unit to the left and all consecutive units with it. This has been fixed by moving the position after the offset has been copied instead of before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were 2 issues to address, 1 with reading and 1 with writing.
Reading: if the offset needed to be moved (due to a negative value in the strengths array), the current position of the offset nor the position of the bounds were taken into account.
Writing: if the very first value was not at the starting position of the heatmap, it would incorrectly move this value one unit to the left and all consecutive units with it. This has been fixed by moving the position after the offset has been copied instead of before.