-
Notifications
You must be signed in to change notification settings - Fork 87
Open
Description
Hi,
I have a config like this:
auto bond2
iface bond2
bond-mode 802.3ad
bond-miimon 100
bond-slaves enp194s0f0np0 enp194s0f1np1
bridge-allow-untagged no
bridge-vids 100-101 119-129
auto vmbr2
iface vmbr2
bridge-ports bond2
bridge-vlan-aware yes
# https://vincent.bernat.ch/en/blog/2017-linux-bridge-isolation
pre-up /sbin/bridge vlan del dev vmbr2 vid 1 self
bridge-ports-condone-regex ^tap
And ifquery -c bond2 complains:
auto bond2
iface bond2 (bridge pvid error) [fail]
bond-slaves enp194s0f0np0 enp194s0f1np1 [pass]
bond-mode 802.3ad [pass]
bond-miimon 100 [pass]
bridge-vids 100-101 119-129 [pass]
This seems to come from
ifupdown2/ifupdown2/addons/bridge.py
Lines 3805 to 3807 in cd74f0d
| elif not running_pvid or running_pvid != 1: | |
| ifaceobjcurr.status = ifaceStatus.ERROR | |
| ifaceobjcurr.status_str = 'bridge pvid error' |
And I have no idea what that condition is supposed to actually do.
Maybe elif running_pvid: would be the correct check?
(The comparison of running_pvid and pvid seems overly complicated. I think one should pick proper values representing the "none" state and just check the values for equality.)
The ifquery output also doesn't show the bridge-allow-untagged line...
Metadata
Metadata
Assignees
Labels
No labels