remove unnecessary print#9
Open
psifertex wants to merge 3 commits into
Open
Conversation
Convert an unnecessary print (really should probably just be removed but I changed it to a log_debug so if you really want to still see the message you can in debug mode.
Contributor
Author
|
Actually, it's worse than that. If you make a new file it won't have an arch at all and you fill your logs with errors: I'll amend my PR to guard for that too. |
On second though, removing the log entirely as in the case of no arch there isn't even a name to print. Best to just remove it.
alexrp
reviewed
Jun 13, 2023
| return True | ||
| else: | ||
| print(f'ClassyPP: Executable CPU Arch is: {bv.arch.name}. This plugin supports only x86 32/64 bit executables.') | ||
| return False |
There was a problem hiding this comment.
Did you mean to remove the return False?
Contributor
Author
There was a problem hiding this comment.
Hmm, I don't think so, I think I was planning on just moving it to the top level but looks like it got eaten. It might default to false on the core side so it might have just worked accidentally, but agree leaving it is best.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert an unnecessary print. Really should probably just be removed, but I changed it to a log_debug so if you really want to still see the message you can in debug mode.