Skip to content

Comments

Increase width of the add/del bar#4

Open
wilzbach wants to merge 1 commit intoCyberShadow:masterfrom
wilzbach:increase-add-del-width
Open

Increase width of the add/del bar#4
wilzbach wants to merge 1 commit intoCyberShadow:masterfrom
wilzbach:increase-add-del-width

Conversation

@wilzbach
Copy link

@wilzbach wilzbach commented Feb 5, 2018

For big PRs, it's typically quite hard to see which files have the biggest changes. Also the nice bar is hardly visible in general.
This has been bothering me for a while now and I finally got around looking into it.
Preview:

image

What do you think? Even bigger?

@CyberShadow
Copy link
Owner

I was planning on making it generate a tree instead of printing the full path for every file... that should fix display even for very nested hierarchies, like those generated by DDox.

@wilzbach
Copy link
Author

wilzbach commented Feb 5, 2018

Yeah that would be really nice :)
BTW a simple improvement would also be to sort the files by their diff size as this solves the use case where a small modification creates a one-line change in almost all files and the reviewer is only interested in the main file and and one or two of the changed files, but the files with the biggest diff changes should have priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants