refactor: remove NotImplemented exception usage#21
Open
deepsource-dev-autofix[bot] wants to merge 1 commit intomasterfrom
Open
refactor: remove NotImplemented exception usage#21deepsource-dev-autofix[bot] wants to merge 1 commit intomasterfrom
NotImplemented exception usage#21deepsource-dev-autofix[bot] wants to merge 1 commit intomasterfrom
Conversation
**Fixes are generated by AI. Review them carefully before applying to your codebase.**
This pull request addresses a DeepSource issue related to the incorrect use of the `NotImplemented` constant.
Key changes include:
- **raising `NotImplemented` is not allowed:**
- **Issue:** The `NotImplemented` constant is intended to be returned by binary special methods (e.g., `__eq__`, `__lt__`) to indicate that an operation is not implemented with respect to the other type. Raising it as an exception (`raise NotImplemented`) is generally incorrect and can lead to a `TypeError` in Python, as it's not designed to be caught like standard exceptions.
- **Fix:** The code has been updated to replace instances of `raise NotImplemented` with `raise NotImplementedError`. This change ensures that an appropriate and standard exception is raised when a feature or method is intentionally not implemented, improving code clarity and adherence to Python best practices.
deepsource-dev-autofix
bot
requested a review
from srijan-deepsource
as a code owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes are generated by AI. Review them carefully before applying to your codebase.
This pull request addresses a DeepSource issue related to the incorrect use of the
NotImplementedconstant.Key changes include:
NotImplementedis not allowed:NotImplementedconstant is intended to be returned by binary special methods (e.g.,__eq__,__lt__) to indicate that an operation is not implemented with respect to the other type. Raising it as an exception (raise NotImplemented) is generally incorrect and can lead to aTypeErrorin Python, as it's not designed to be caught like standard exceptions.raise NotImplementedwithraise NotImplementedError. This change ensures that an appropriate and standard exception is raised when a feature or method is intentionally not implemented, improving code clarity and adherence to Python best practices.