refactor: replace dangerous mutable default argument#23
Open
deepsource-dev-autofix[bot] wants to merge 1 commit intomasterfrom
Open
refactor: replace dangerous mutable default argument#23deepsource-dev-autofix[bot] wants to merge 1 commit intomasterfrom
deepsource-dev-autofix[bot] wants to merge 1 commit intomasterfrom
Conversation
**Fixes are generated by AI. Review them carefully before applying to your codebase.** This PR refactors function parameters to avoid mutable default arguments and prevent state persistence across calls. - Dangerous default argument: Functions using mutable defaults such as lists or dictionaries may retain state across invocations, leading to unintended side effects. We replaced the default argument with None and added a conditional inside the function to initialize a new object when the parameter is None. This ensures each function call operates on a fresh instance and avoids persistent state issues.
deepsource-dev-autofix
bot
requested a review
from srijan-deepsource
as a code owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes are generated by AI. Review them carefully before applying to your codebase.
This PR refactors function parameters to avoid mutable default arguments and prevent state persistence across calls.