refactor: remove unnecessary comprehension#28
Open
deepsource-dev-autofix[bot] wants to merge 1 commit intomasterfrom
Open
refactor: remove unnecessary comprehension#28deepsource-dev-autofix[bot] wants to merge 1 commit intomasterfrom
deepsource-dev-autofix[bot] wants to merge 1 commit intomasterfrom
Conversation
This PR refactors calls to all() by replacing unnecessary list comprehensions with generator expressions for better performance and readability. - Unnecessary comprehension: The code originally used all([isinstance(i, int) for i in min_max]) which created an intermediate list on each call. All three instances have been updated to all(isinstance(i, int) for i in min_max), leveraging a generator expression to avoid needless list allocation. > This Autofix was generated by AI. Please review the change before merging.
deepsource-dev-autofix
bot
requested a review
from srijan-deepsource
as a code owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors calls to all() by replacing unnecessary list comprehensions with generator expressions for better performance and readability.