Conversation
PHP 8.5 has been GA since November 2025. Add it to the CI test matrix to verify runtime compatibility. The existing platform.php override (8.1.27) ensures composer install works with locked deps.
There was a problem hiding this comment.
Pull request overview
This PR is critically misrepresented in its title and description. While titled "[TASK] Add PHP 8.5 to CI test matrix," it actually contains extensive functionality additions including a complete image zoom system with 4 modes (lightbox, gallery, inline, lens), new directives, error handling improvements, dependency updates, and test infrastructure changes.
Changes:
- Adds PHP 8.5 to CI test matrix (as described)
- Implements complete image zoom functionality with JavaScript, CSS, and Twig templates
- Adds new FigureDirective with zoom support and InvalidGuidesXmlTest
- Updates multiple dependencies (React 19.2.4, Vite 7.3.1, Symfony components, dev tools)
- Improves error handling for invalid guides.xml configuration
- Updates documentation format and adds extensive zoom examples
Reviewed changes
Copilot reviewed 37 out of 43 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/main.yaml | Adds PHP 8.5 to test matrix |
| tests/Integration/InvalidGuidesXmlTest.php | New test for invalid guides.xml error handling |
| tests/fixtures/invalid-guides-xml/* | New fixtures for testing configuration errors |
| tests/Integration/tests/images/Zoom/* | New integration test for image zoom functionality |
| packages/typo3-docs-theme/src/Directives/FigureDirective.php | New custom figure directive with zoom validation |
| packages/typo3-docs-theme/assets/js/image-zoom.js | 1195 lines of JavaScript for 4 zoom modes |
| packages/typo3-docs-theme/assets/sass/_component_image_zoom.scss | 357 lines of CSS for zoom components |
| packages/typo3-docs-theme/resources/template/body/* | Templates for image and figure zoom support |
| packages/typo3-docs-theme/package.json | Updates React, Vite, Sass, and other frontend dependencies |
| composer.lock | Updates Symfony and development dependencies |
| bin/guides | Adds error handling for InvalidConfigurationException |
| README.rst | Fixes ReST link formatting |
| Documentation-rendertest/ImagesAndFigures/Index.rst | Adds extensive zoom mode examples |
Files not reviewed (1)
- packages/typo3-docs-theme/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/gemini review |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Summary
platform.php: 8.1.27ensures locked install works)Changes
.github/workflows/main.yaml: Added'8.5'tomatrix.phpin thetestsjobContext
PHP 8.5 has been GA since November 2025. The existing
composer.jsonconstraint(
^8.1) already allows 8.5. Theconfig.platform.php: 8.1.27setting ensurescomposer install --lockedsucceeds regardless of runtime PHP version.Upstream PR
Test plan