Conversation
## Summary - Adds PHP 8.5 (stable since Nov 2025, current: 8.5.3) to the CI test matrix - Tests unit and integration suites against PHP 8.5 - No dependency or config changes needed (`platform.php: 8.1.27` ensures locked install works) ## Changes - `.github/workflows/main.yaml`: Added `'8.5'` to `matrix.php` in the `tests` job ## Context PHP 8.5 has been GA since November 2025. The existing `composer.json` constraint (`^8.1`) already allows 8.5. The `config.platform.php: 8.1.27` setting ensures `composer install --locked` succeeds regardless of runtime PHP version. ## Test plan - [ ] CI runs unit tests on PHP 8.5 - [ ] CI runs integration tests on PHP 8.5 - [ ] Existing PHP 8.1-8.4 jobs unaffected
- PHP 8.1 reached EOL December 2025, update local dev to 8.5 - Node.js 18 reached EOL April 2025, update to 24 (active LTS) - Local development only, does not affect CI or project minimum
There was a problem hiding this comment.
Pull request overview
This PR attempts to update the DDEV local development environment to use newer versions of PHP and Node.js, citing end-of-life concerns for PHP 8.1 and Node.js 18. However, the versions specified (PHP 8.5 and Node.js 24) do not exist yet as of January 2025. The PR also adds PHP 8.5 to the CI workflow matrix, which contradicts the stated intent of affecting local development only.
Changes:
- Updated
php_versionin.ddev/config.yamlfrom 8.1 to 8.5 - Updated
nodejs_versionin.ddev/config.yamlfrom 18 to 24 - Added PHP 8.5 to the CI workflow test matrix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .ddev/config.yaml | Updates PHP version to 8.5 and Node.js version to 24 for DDEV local development environment |
| .github/workflows/main.yaml | Adds PHP 8.5 to the CI test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - '8.2' | ||
| - '8.3' | ||
| - '8.4' | ||
| - '8.5' |
There was a problem hiding this comment.
This change to the CI workflow contradicts the PR description, which explicitly states "Local development only, does not affect CI or project PHP minimum". Adding PHP 8.5 to the CI test matrix affects CI and should either be removed from this PR or the PR description should be updated to reflect this change.
1 participant
Summary
php_versionfrom 8.1 (EOL Dec 2025) to 8.5 in.ddev/config.yamlnodejs_versionfrom 18 (EOL Apr 2025) to 24 (active LTS)Test plan
ddev startsucceeds with PHP 8.5ddev npm-buildworks with Node.js 24