can't run workflow

[omarcostahamido]

just back into min sdk.
I was trying to explore now the github actions workflow, cause if it can build both the mac universal and windows externals then it will save me some good time moving forward.
tried running it and the first step fails with

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

it seems something needs updating here. I will continue to investigate a bit more and update here :)

OCH

[isabelgk]

https://github.com/Cycling74/min-package-template/blob/main/.github/workflows/main.yml This might help get you started

…

On Mon, May 19, 2025 at 5:12 PM OCH ***@***.***> wrote: *omarcostahamido* created an issue (Cycling74/min-devkit#226) <#226> just back into min sdk. I was trying to explore now the github actions workflow, cause if it can build both the mac universal and windows externals then it will save me some good time moving forward. tried running it and the first step fails with Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/ it seems something needs updating here. I will continue to investigate a bit more and update here :) OCH — Reply to this email directly, view it on GitHub <#226>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADH4A2PCU35H6ZCJHFSEXML27JCKBAVCNFSM6AAAAAB5OXWEHCVHI2DSMVQWIX3LMV43ASLTON2WKOZTGA3TKMBSHE4TMMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[isabelgk]

(This change hasn’t been propagated to all appropriate repositories yet…) On Mon, May 19, 2025 at 5:14 PM Isabel Kaspriskie ***@***.***> wrote:

…

https://github.com/Cycling74/min-package-template/blob/main/.github/workflows/main.yml This might help get you started On Mon, May 19, 2025 at 5:12 PM OCH ***@***.***> wrote: > *omarcostahamido* created an issue (Cycling74/min-devkit#226) > <#226> > > just back into min sdk. > I was trying to explore now the github actions workflow, cause if it can > build both the mac universal and windows externals then it will save me > some good time moving forward. > tried running it and the first step fails with > > Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/ > > it seems something needs updating here. I will continue to investigate a > bit more and update here :) > > OCH > > — > Reply to this email directly, view it on GitHub > <#226>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADH4A2PCU35H6ZCJHFSEXML27JCKBAVCNFSM6AAAAAB5OXWEHCVHI2DSMVQWIX3LMV43ASLTON2WKOZTGA3TKMBSHE4TMMA> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >

[omarcostahamido]

hello again @isabelgk
I managed to track it down and I will add a PR.
needed to change version number of some actions. (and also changed the checkout to v4 which is much faster as well)

Still it fails to build the windows version:

and because of that it doesn't end with a release?

My processo to trigger this was to create a release - i don't know how to create a tag without creating a release :/

The first part of the macos externals go all well (thogh more than 4 minutes) and the windows fails because an artifact with this name already exists?

edit:

https://github.com/Cycling74/min-package-template/blob/main/.github/workflows/main.yml
This might help get you started

oh! I didn't realize there was a min-package-template repo. What is the difference, should I be looking there instead this whole time?

(This change hasn’t been propagated to all appropriate repositories yet…)

how does that propagation works? manually? :)

[omarcostahamido]

hi @isabelgk
(the PR is up)

question: on line 30 of the main.yml
it says: run: mkdir build && cd build && cmake -G Xcode .. "-DCMAKE_OSX_ARCHITECTURES=x86_64;arm64"
but the same line on this new template repo only says: run: mkdir build && cd build && cmake -G Xcode ..
isn't that going to risk those externals to be non-universal, as in for only intel or arm?

[omarcostahamido]

@isabelgk wait don't merge it yet, I think i found the answer to my question here

uses: actions/upload-artifact@v4
      with:
        name: ${{ github.event.repository.name }}-${{ steps.short-sha.outputs.sha }}-${{ matrix.config }}

should be

uses: actions/upload-artifact@v4
      with:
        name: ${{ github.event.repository.name }}-${{ steps.short-sha.outputs.sha }}-${{ matrix.config }}-${{ matrix.os }}

btw, I am seeing other things in the template version that seem outdated when compared to this version.

[omarcostahamido]

I've dropped a PR on the template repo as well 😇
Cycling74/min-package-template#1

[omarcostahamido]

hi @isabelgk
can you see the deployment report of my fork here?
https://github.com/omarcostahamido/min-devkit/actions/runs/15199616380/job/42751224473
it seems that it is still failing retrieving the windows build :(
I tried editing the line that searches for a specific name to match the name that is set above, but with no success.
What do you think?

[isabelgk]

I can see your deployment report, yes!

I see this on the Release step:
Artifact not found for name: min-devkit-34f7584--

On the package step, I see:

Artifact min-devkit-34f7584-release-windows-latest.zip successfully finalized. Artifact ID 3181671238
Artifact min-devkit-34f7584-release-windows-latest has been successfully uploaded! Final size is 10947946 bytes. Artifact ID is 3181671238
Artifact download URL: https://github.com/omarcostahamido/min-devkit/actions/runs/15199616380/artifacts/3181671238

I think the Release step needs to match. Is this what you also have concluded? Maybe there's something about path that also has to change (as well as the already changed name)... That's my first guess!

[isabelgk]

Hi @omarcostahamido ! I'm coming back to check on open bugs and was wondering if you were able to resolve this in the end?